Refactor code changes #917
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stleary
reviewed
Nov 26, 2024
| @@ -328,8 +328,7 @@ public static String valueToString(Object value) throws JSONException { | |||
| // Instead we will quote it as a string | |||
| return JSONObject.quote(numberAsString); | |||
| } | |||
| if (value instanceof Boolean || value instanceof JSONObject | |||
| || value instanceof JSONArray) { | |||
| if (isDirectlyConvertibleToJSON(value)) { | |||
There was a problem hiding this comment.
Please revert this change. A separate method is not needed for this conditional. You can add a clarification comment if you want.
stleary
reviewed
Nov 26, 2024
| @@ -349,6 +348,10 @@ public static String valueToString(Object value) throws JSONException { | |||
| return JSONObject.quote(value.toString()); | |||
| } | |||
|
|
|||
| private static boolean isDirectlyConvertibleToJSON(Object value) { | |||
There was a problem hiding this comment.
General rule: All methods must include JavaDoc comment
stleary
reviewed
Nov 26, 2024
| sb.append(jo.getString("Status-Code")); | ||
| sb.append(' '); | ||
| sb.append(jo.getString("Reason-Phrase")); | ||
| appendResponseHeader(sb, jo); |
There was a problem hiding this comment.
Please revert all changes to toString(). Refactoring this code is a judgement call. In this case, I trust Douglas Crockford's decision to include all HTTP string conversions in a single method.
|
@devpatel43543 review comments added. The changes to JSONObject look good. All else should be reverted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hii @stleary
i have refactored changes in following 3 files to enhance readability and maintainability:
Decompose Conditional in
valueToString()(JSONWriter.java):isDirectlyConvertibleToJSON()) to improve readability.Commit
Extract Method in
toString()(HTTP.java):Commit
Rename Variable in
JSONObject:x→jsonTokener,c→currentChar) for better clarity and readability.